add v4 board def #22
add v4 board def #22
Conversation
|
Ran it on my machine! Looks great formatting wise, a few suggestions
but yea formatting is great looking really good! Sorry for adding the commits, I was just trying to experiement with what was missing! |
|
@ineskhou Updated the filenames, hopefully this is complete for now. |
yudataguy
requested review from
Mikefly123 and
ineskhou
and removed request for
Mikefly123 and
ineskhou
|
Update on my comments from before, it seems that we do not need the m0p definitions/format. Apologies for that -- I saw the settings.ini had rp2040/m0p, but we can just return to the rp2040 definition like in the You will run into build issues, but that's probably specifically because of the board definitions and not because of the exclusion of the m0p from my understanding? Mahdav said he would take a look at the build issues, and I will try to look at it later tonight as well |
| board_runner_args(uf2 "--board-id=RP2340") | ||
| if(BOARD MATCHES "^proves_flight_control_board_v4") | ||
| board_runner_args(openocd --cmd-pre-init "source [find target/rp2040.cfg]") | ||
| board_runner_args(jlink "--device=RP2040_M0_0") |
There was a problem hiding this comment.
@ineskhou Is this what you're referring to?
| @@ -0,0 +1,22 @@ | |||
| identifier: proves_flight_control_board_v4b/rp2040/m0p | |||
There was a problem hiding this comment.
@ineskhou is this what you're referring to?
settings.ini
Outdated
| FPRIME_ENABLE_AUTOCODER_UTS=OFF | ||
| BOARD_ROOT=. | ||
| BOARD=proves_flight_control_board_v5c/rp2350a/m33 | ||
| BOARD=proves_flight_control_board_v4b/rp2040/m0p |
There was a problem hiding this comment.
Yes here! Settings.ini -- and you should probably make sure the others match up but it should say:
"proves_flight_control_board_v4b/rp2040"
This will generate correctly (it does on mine) unlike the other commits. there will be build errors but from talking to Mahdav I believe those are just things missing in the device tree
There was a problem hiding this comment.
Any idea on how to fix the device tree?
Mikefly123
left a comment
Mikefly123
left a comment
There was a problem hiding this comment.
Hey @yudataguy! I went through and made some recommendations on changes to the board definition to match the pinout on the V4b Flight Controller Boards.
Reference V4b RP2040 Pinout Screenshot
| compatible = "semtech,sx1276"; | ||
| reg = <0>; | ||
| spi-max-frequency = <125000>; | ||
| dio-gpios = <&gpio0 13 (GPIO_PULL_DOWN | GPIO_ACTIVE_HIGH)>,<&gpio0 12 (GPIO_PULL_DOWN | GPIO_ACTIVE_HIGH)>; |
There was a problem hiding this comment.
I think we reached the conclusion last week that we would only be using the DIO0 part of the library for now. On V4b boards this is the pin location:
| dio-gpios = <&gpio0 13 (GPIO_PULL_DOWN | GPIO_ACTIVE_HIGH)>,<&gpio0 12 (GPIO_PULL_DOWN | GPIO_ACTIVE_HIGH)>; | |
| dio-gpios = <&gpio0 23 (GPIO_PULL_DOWN | GPIO_ACTIVE_HIGH)>; |
| reg = <0>; | ||
| spi-max-frequency = <125000>; | ||
| dio-gpios = <&gpio0 13 (GPIO_PULL_DOWN | GPIO_ACTIVE_HIGH)>,<&gpio0 12 (GPIO_PULL_DOWN | GPIO_ACTIVE_HIGH)>; | ||
| reset-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; |
There was a problem hiding this comment.
This is also different from V5 to V4
| reset-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; | |
| reset-gpios = <&gpio0 20 GPIO_ACTIVE_LOW>; |
| ina219: ina219@40 { | ||
| compatible = "ti,ina219"; | ||
| reg = <0x40>; | ||
| shunt-milliohm = <2>; | ||
| lsb-microamp = <100>; | ||
| label = "INA219"; | ||
| }; |
There was a problem hiding this comment.
There is no onboard INA219 on the V4 Flight Controller Board.
| ina219: ina219@40 { | |
| compatible = "ti,ina219"; | |
| reg = <0x40>; | |
| shunt-milliohm = <2>; | |
| lsb-microamp = <100>; | |
| label = "INA219"; | |
| }; |
Added v4 board definition. Still several points unclear
haven't build yet, feedback welcome